Conversation
I'm creating a demo folder. data/eorca contains eorca (ssh data) netcdf files
creation of notebook folder
Amine-ouhechou
left a comment
Amine-ouhechou
left a comment
There was a problem hiding this comment.
Hi Micael,
I didn't accept the pull request because I don’t think it’s appropriate to include data files directly in the repository. Also, in the /utils folder, there’s a lot of redundant code—essentially a full copy—which isn’t necessary.
The idea of a demo notebook is great, but it would be better to include only the notebook itself, without duplicating the existing code.
Could you make these adjustments and submit a new pull request?
|
Hello Amine, What does Julien say about? Anyway, I can remove all data files and the utils folder |
2 participants
I'm creating a demo folder that contains
1- data/eorca/ containing ssh data and the mask
2- interpolated_data/ to store the interpolated data files
3 - notebook/ containing the python code file
4- swot_grid_files/ containing the traget grid files
5- utils/ contaning tools for interpolation